Skip to content

fix: defer inline login enrollment#6088

Open
rebelchris wants to merge 2 commits into
mainfrom
codex/defer-inline-login-enrollment
Open

fix: defer inline login enrollment#6088
rebelchris wants to merge 2 commits into
mainfrom
codex/defer-inline-login-enrollment

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented May 21, 2026 •
edited by github-actions Bot
Loading

Summary

  • defer inline_login evaluation until auth intent calls showLogin
  • remove inline login state from AuthContext and read GrowthBook directly at the click boundary
  • use useConditionalFeature in _app with shouldEvaluate gated by shouldShowLogin

Tests

  • node ./scripts/typecheck-strict-changed.js
  • pnpm --filter shared test -- src/contexts/BootProvider.spec.tsx
  • pnpm --filter webapp exec eslint pages/_app.tsx --max-warnings 0
  • pnpm --filter webapp build:notls

Preview domain

https://codex-defer-inline-login-enrollm.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 21, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 21, 2026 10:12am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 21, 2026 10:12am

Request Review

@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from e985dae to 52fe5b0 Compare May 21, 2026 07:44
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from 52fe5b0 to cbab975 Compare May 21, 2026 07:50
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from cbab975 to 08bab4e Compare May 21, 2026 07:57
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from 08bab4e to dc0e766 Compare May 21, 2026 08:04
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from dc0e766 to 1560447 Compare May 21, 2026 08:19
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from 1560447 to 93cb970 Compare May 21, 2026 08:58
@rebelchris rebelchris requested review from capJavert and idoshamun May 21, 2026 09:03
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from 232aaa6 to 5269b04 Compare May 21, 2026 10:01
@rebelchris rebelchris force-pushed the codex/defer-inline-login-enrollment branch from 5269b04 to 5941e43 Compare May 21, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@capJavert capJavert capJavert approved these changes

@idoshamun idoshamun Awaiting requested review from idoshamun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rebelchris @capJavert